improve: speed up desktop editing and export with window and menu fixes - #2215
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MP4 exports decode entire audio sources before the first frame, while editor previews repeat cursor, caption and waveform preparation. This adds bounded streaming audio for supported MP4 timelines, overlaps source preparation with renderer setup, indexes cursor lookups, prepares export zoom incrementally and avoids redundant sample copies and screenshot compositing. Unsupported timelines and destinations retain the existing export path. Cancellation and failures join workers, remove private temporary output and preserve retries; completed files retain the existing permission behavior.
The desktop changes also anchor menus to their buttons, improve selected states and drag cursors, dismiss indexed menus after clip deletion/history changes, and retain Windows caption controls during loading, errors and overlays. Window capture filters out invalid Windows targets, and committed app handoffs finish if the settings window closes. Editor controls and saves stay disabled until the loaded configuration and engine are published together. Cursor sampling preserves texture derivatives at sprite edges. Camera antialiasing derivatives are evaluated before pixel-dependent early returns, fixing distant camera-edge pixels exposed by the Windows cursor/ripple regression test.
Validation at
0886c8c3:Performance evidence has narrower coverage than release acceptance. Earlier native Mac testing of the export implementation covered 99 cases, decoded video/audio equivalence, timestamps, cancellation, dropped futures and retries. One eight-second excerpt improved builder-to-first-frame time from 5.20s to 0.49s and peak export-process memory from 1.09GB to 274MB; total export changed from 5.96s to 5.34s. Those fixture-specific measurements predate the final UI, permission and camera fixes.
The hosted performance run used production-identical source (the successor commit changes only a test parser): all three Mac tests executed, while Windows skipped all three on its software adapter. Between two different Mac runner OS images, playback improved from 52.64 to 68.34fps but export fell from 50.57 to 41.65fps; these single runs do not establish the cause. A separate same-Mac compositor comparison measured approximately 0.039ms extra per default 4K camera draw and 0.068ms with borders for the antialiasing correction. This does not establish its effect on total export throughput.
Human-test packages from the merged desktop source are available for Apple Silicon macOS and Linux. The Mac app passed signing, notarization and stapling; Linux passed package-content and updater-signature checks. Intel macOS and Windows packages are still building. These Actions artifacts expire September 6; the release remains a draft.
Human acceptance before release should cover the prepared export path on physical Windows/Linux hardware, clipboard output, loading/edit/save behavior, cancellation/retry, long-session memory, and playback/export throughput on consistent hardware. The full 20-hour editor memory target and direct native clipboard prototype are outside this change. The historical settings-reset writer was not conclusively identified; the reproduced loading/save risk is guarded here.
Greptile Summary
The PR accelerates desktop editing and MP4 export while tightening editor loading, menu, window-control, and cancellation behavior.
Confidence Score: 5/5
The PR appears safe to merge based on the reviewed changes and available prior-thread context.
No blocking failure remains.
Important Files Changed
Reviews (6): Last reviewed commit: "test: accept Windows shader line endings" | Re-trigger Greptile